search

puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 354 forks source link

r10k puppetfile install does not adhere to global exclude_spec false #1392

Open vicinus opened 4 months ago

vicinus commented 4 months ago

Describe the Bug

r10k puppetfile install removes the spec directories of the modules even if in the r10k.yaml configuration file is globally set, that the spec directories should not be removed:

deploy:
  exclude_spec: false

It works if in the Puppetfile for every module exclude_spec: false is set.

Expected Behavior

r10k puppetfile install should not remove the spec directories if in the r10k.yaml configuration file is globally set, that the spec directories should not be removed.

Steps to Reproduce

  1. Setup a Puppetfile with a module, that has a spec directory: 
    mod 'puppetlabs/apache',
:git => 'https://github.com/puppetlabs/puppetlabs-apache.git',
:ref => 'v12.1.0'
  2. Setup a r10k.yaml file which disabled spec directory removal: 
    deploy:
exclude_spec: false
  3. Run r10k puppetfile install --config=r10k.yaml

Environment

r10k version 4.1.0

github-actions[bot] commented 2 months ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

vicinus commented 2 months ago

...

github-actions[bot] commented 1 week ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

vicinus commented 1 week ago

...