search

puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 353 forks source link

Support for plain tarballs #567

Closed dannytrigo closed 3 years ago

dannytrigo commented 8 years ago

I would like to support downloading Puppet module tarballs from plain HTTP URLs, not just from Puppet Forge. For example: mod "mymodule", :tarball => "http://puppetrepo/me-mymodule-1.0.13.tar.gz"

I find it strange that this doesn't already exist, when a tarball is a standard packaging format for modules (puppet module build). Is there a reason for it not already existing, or it simply needs implementing?

Cinderhaze commented 7 years ago

I would love for support like this, as well as potentially support for s3 based urls

rnelson0 commented 7 years ago

@dannytrigo I am not sure it is encouraged, but doubt it would be frowned upon as an option. If it is implemented well - including tests and docs - I am pretty sure it could be merged.

My concern as a user is how much of an impact that would have on deployment times and how it would verify authenticity (esp with a high likelyhood of self-signed certs with https).

scotje commented 7 years ago

@dannytrigo How would you want to determine whether or not the module needed to be updated/redeployed? Theoretically it could just redeploy every time r10k deploys the environment, but that seems pretty inefficient. We could also just require a certain format to the tarball URL that includes a version number, or have a separate key to declare the desired version.

Cinderhaze commented 7 years ago

I know that in our usecase, having an http mirror of forge tarballs, requiring the tar file to have the version in it is enough.

github-actions[bot] commented 3 years ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.