search

puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 354 forks source link

Cannot use r10k puppetfile check when a git module is tracking the control repo branch #659

Closed chriscowley closed 3 years ago

chriscowley commented 7 years ago

When a module entry in my Puppetfile contains something like:

mod 'profile',
    :git => 'ssh://git@<my-gitlab>/puppet/puppet-profile.git',
    :branch => :control_branch,
    :default_branch => 'master'

running r10k puppetfile check returns an error with the message:

Failed to evaluate /<path-to-controlrepo>/Puppetfile
Original exception:
Cannot track control repo branch from Puppetfile in this context: environment is nil or did not provide a valid ref
scotje commented 7 years ago

Indeed, I'll see if I can add a condition to puppetfile check for this.

scotje commented 7 years ago

Created https://tickets.puppetlabs.com/browse/RK-269 to track this.

andersonmills commented 7 years ago

698 has been merged. We should be publishing 2.5.2 soon with the fix.

tuxmea commented 3 years ago

this is solved logn ago. can we close this issue?

github-actions[bot] commented 3 years ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.