Open danadoherty639 opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.80%. Comparing base (
2c8b9cf
) to head (bb5ec3f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any reason you need to use {{ site.url }}
instead of {{ site.baseurl }}
?
Any reason you need to use
{{ site.url }}
instead of{{ site.baseurl }}
?
Ive tested this with baseurl but if I remember, it broke the css, I will test this out again this morning before opening the PR
Summary
The jekyll gh-pages action "sources" its documentation from the root "/" of the repository however respec-puppet holds its documentation under a sub-directory
/docs
. This points the action to the correct directory to build the documention from with more advanced configuration options under/docs/config.yml
. This PR also fixes the issue with the broken links by using Jekyll's global variablesite.url
configured in/docs/config.yaml
. The default css theming is expected to be served from the default root directory and ours isrespec-puppet
and thesite.url
is used to fixed this and serve the css from the correct location.Related Issues (if any)
Mention any related issues or pull requests.
Checklist