search

puppetlabs / rspec-puppet

RSpec tests for your Puppet manifests
https://puppetlabs.github.io/rspec-puppet/
MIT License
11 stars 18 forks source link

Restore changelog of < 2.10.0 #83

Closed ekohl closed 8 months ago

ekohl commented 8 months ago

Fixes: fab98f3a3403666549eda065595b412b84d619ed ("Release prep v3.0.0-rc.1")

jordanbreen28 commented 8 months ago

hey @ekohl - thanks for this! It's worth noting that the changelog generator we use will overwrite the changes in CHANGELOG.md when run again (it has no HISTORY.md support as of yet either..), but I appreciate your efforts in assigning the older missing entries into a HISTORY.md. This should help to cover the missing changelog entries until (or if) we get history.md supported added to the changelog generator.

ekohl commented 8 months ago

Ah, you're not using GitHubChangelogGenerator anymore?

jordanbreen28 commented 8 months ago

@ekohl unfortunately not, we made the jump to gh-changelog as we were encountering issues with github_changelog_generator 👎 For now, I re-added your entries back in when they were overwritten in https://github.com/puppetlabs/rspec-puppet/pull/84 as they are really nice to have. Might be something we try to implement as a feature on gh-changelog to add HISTORY.md support, which would be a big plus. Give us a chance to brush up on the go skills 💯

jordanbreen28 commented 8 months ago

Awk! Or so I thought I could... https://github.com/puppetlabs/rspec-puppet/actions/runs/6559637726/job/17815618452

ekohl commented 8 months ago

I've also seen plenty of issues with GitHubChangelogGenerator so I'm not particularly attached to it.