(bug) - Fixes missing mandatory ID - Githubissues

puppetlabs / ruby-pwsh

A ruby gem for interacting with PowerShell

MIT License

15 stars 21 forks source link

(bug) - Fixes missing mandatory ID #234

Closed jordanbreen28 closed 1 year ago

jordanbreen28 commented 1 year ago

Summary

This is a continuation of https://github.com/puppetlabs/ruby-pwsh/pull/204 by https://github.com/Hvid & https://github.com/ShawnHardwick.

Fixes https://github.com/puppetlabs/ruby-pwsh/issues/203 and https://github.com/puppetlabs/Puppet.Dsc/issues/242

This is just copied from the comment by https://github.com/ShawnHardwick

Checklist

[x] 🟢 Spec tests.
[x] 🟢 Acceptance tests.
[x] Manually verified. (By users in https://github.com/puppetlabs/ruby-pwsh/issues/203 and https://github.com/puppetlabs/Puppet.Dsc/issues/242)

We can say with confidence that this change should not break existing DSC functionality thanks to tests added from these issues: https://github.com/puppetlabs/ruby-pwsh/issues/163 https://github.com/puppetlabs/ruby-pwsh/issues/164 https://github.com/puppetlabs/ruby-pwsh/issues/165

These tests thoroughly test changes to the dsc base provider against published dsc modules.