(CAT-1724) - Adjust stringify_nil_attrs to include Enum - Githubissues

puppetlabs / ruby-pwsh

A ruby gem for interacting with PowerShell

MIT License

15 stars 21 forks source link

(CAT-1724) - Adjust stringify_nil_attrs to include Enum #296

Closed jordanbreen28 closed 4 months ago

jordanbreen28 commented 4 months ago

Summary

When comparing a resource from manifest that is an empty string to the value set in the system, we have a mismatch between empty_string and nil.

Similarly what we done for nil strings, we can extend to nil Enums returned by DSC.

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

[ ] Root cause and the steps to reproduce. (If applicable)
[ ] Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

[ ] 🟢 Spec tests.
[ ] 🟢 Acceptance tests.
[x] Manually verified.

jordanbreen28 commented 4 months ago

Unsuitable approach. Caused unexpected behaviour.