puppetlabs / ruby-pwsh

A ruby gem for interacting with PowerShell
MIT License
15 stars 24 forks source link

double quote when passing env var values #351

Closed garrettrowell closed 1 month ago

garrettrowell commented 1 month ago

Summary

Double quote the values of environment variables to ensure values containing spaces are properly passed.

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_hash_tables?view=powershell-7.4#iterating-over-keys-and-values

Checklist

jordanbreen28 commented 1 month ago

@garrettrowell thanks for this, nice catch. Could you rebase off main to get rid of the merge commit and we'll go ahead and merge this in?

garrettrowell commented 1 month ago

@jordanbreen28 thanks, this should be rebased now