puppetlabs / trapperkeeper

A services framework for Clojure / JVM applications.
https://tickets.puppetlabs.com/browse/TK
Apache License 2.0
587 stars 74 forks source link

Test code should reflect what is being tested #284

Closed oneness closed 5 years ago

oneness commented 5 years ago

First of all, thanks for open sourcing this library. I poked around a bit and found that the lib provides just about the right abstraction that can be used to turn various infrastructure services into reusable components. Another side benefit of this is to help with deploying and scaling distributed services. Nice work and keep it up!

I did found an incorrect test and changed the code to reflect what is being tested. I understand that you guys use JIRA (which I am not a fan of) for PRs/issues but just putting it out there so you can either merge this or just update with the code as you guys see fit.