search

puppetlabs / trapperkeeper

A services framework for Clojure / JVM applications.
https://tickets.puppetlabs.com/browse/TK
Apache License 2.0
587 stars 74 forks source link

Collect exceptions caught during shutdown #297

Closed DeLaGuardo closed 2 years ago

DeLaGuardo commented 2 years ago

fix #292

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

justinstoller commented 2 years ago

Excellent! Thank you both so much for working on this. Would you mind also updating the CHANGELOG file? We can then do a release with these changes on Monday.

DeLaGuardo commented 2 years ago

Looking forward for the Monday release :)

Also there was three releases missing in CHANGELOG.md. I added some notes based of comparing the tags but please check them out.

And have a great weekend :)

DeLaGuardo commented 2 years ago

Hi! @justinstoller, sorry for bothering you. Are you still planning to cut the release any time soon? The release is not urgent; I want to ensure that I didn't miss something obvious in my PR.

Magisus commented 2 years ago

Thanks for the reminder, we should get on this. I'll look into it today 🙂

Magisus commented 2 years ago

This has been released https://github.com/puppetlabs/trapperkeeper/releases/tag/3.2.0

DeLaGuardo commented 2 years ago

Amazing! Thank you very much for the quick response!