search

puppetlabs / vault-plugin-secrets-oauthapp

OAuth 2.0 secrets plugin for HashiCorp Vault supporting a variety of grant types
Apache License 2.0
94 stars 11 forks source link

Automatic credential refresh messages even though the tuning option set it disabled #57

Closed DrDaveD closed 3 years ago

DrDaveD commented 3 years ago

Describe the Bug

With plugin version 2.2.0 there are messages every minute in /var/log/messages "running automatic credential refresh" even though I set tune_refresh_check_interval_seconds=0.

Expected Behavior

I expect there to be no automatic credential refresh when that configuration variable is 0.

Steps to Reproduce

Set the config tune_refresh_check_interval_seconds=0 and look in /var/log/messages.

Environment

Additional Context

2.2.0 added the debug message so I don't know if the refreshing was actually happening in 2.1.0 and I just didn't notice. I'm also not sure if the problem is only the message or if it is actually refreshing. I could dig deeper to find out.

DrDaveD commented 3 years ago

I investigated more and found that that the value of tune_refresh_check_interval_seconds changed to 60, and I did not re-set the configuration after the upgrade. Resetting the value back to 0 stopped the messages. So the problem seems to be that the value got re-set back to the default during the upgrade. I will test downgrading & updating again to see if it is reproducible.

DrDaveD commented 3 years ago

Downgrading & upgrading didn't cause the problem, and neither did creating the vault database from scratch using version 2.1.0 and then upgrading to 2.2.0. So it's a mystery why the value changed to 60 sometime in the past, but I'll just leave it at that.

DrDaveD commented 3 years ago

I just noticed #55 in version 2.1.1, which I wasn't using, but this seems to have been the opposite problem.