search

puppetlabs / vault-plugin-secrets-oauthapp

OAuth 2.0 secrets plugin for HashiCorp Vault supporting a variety of grant types
Apache License 2.0
94 stars 11 forks source link

Implement basic support for token exchange flow #78

Closed impl closed 1 year ago

impl commented 1 year ago

CC @DrDaveD for feedback, but this should be basically what I talked about in my comment yesterday.

Fair warning: I don't have a good authorization server to test this against; do you know of an open-source one that's easy to set up? Or a free SaaS perhaps? Or just let me know if it seems to work on your side and I'll go ahead and merge it.

impl commented 1 year ago

I'm going to go ahead and merge this, but if you have any concerns, feel free to open an issue or a PR!

DrDaveD commented 1 year ago

I'm sorry I hadn't had a chance to test this yet. I tried to get the google token issuer to work but didn't have any luck. I know there are open source token issuers including those that can do token exchange but I haven't myself run them so I wouldn't be of much help in advising which one to use. I normally use token issuers run by other people.

impl commented 1 year ago

No worries! If it ends up not working the way you expect, we'll just do a point release later and call it good. :)