search

puppets-epic-show-theatre / puppet-nexus

Puppet module for Sonatype Nexus
MIT License
0 stars 12 forks source link

Fix 'notice' #59

Closed PiR-B closed 11 months ago

PiR-B commented 12 months ago

HI @TuningYourCode ,

I wanted to bring to your attention a regression introduced by this pull request : https://github.com/puppets-epic-show-theatre/puppet-nexus/pull/52

Notice: /Stage[main]/Nexus::Config::Email/Nexus_setting[email]/attributes: attributes changed {
  'enabled' => false,
  'host' => 'localhost',
  'port' => 25,
  'username' => '',                                                                    -> Here
  'password' => undef,
  'fromAddress' => 'nexus@example.org',
  'subjectPrefix' => undef,
  'startTlsEnabled' => false,
  'startTlsRequired' => false,
  'sslOnConnectEnabled' => false,
  'sslServerIdentityCheckEnabled' => false,
  'nexusTrustStoreEnabled' => false
} to {
  'enabled' => false,
  'host' => 'localhost',
  'port' => 25,
  'username' => undef,                                                                    -> Here
  'password' => undef,
  'fromAddress' => 'nexus@example.org',
  'subjectPrefix' => undef,
  'startTlsEnabled' => false,
  'startTlsRequired' => false,
  'sslOnConnectEnabled' => false,
  'sslServerIdentityCheckEnabled' => false,
  'nexusTrustStoreEnabled' => false
} (corrective)

I initially attempted to adhere to the best practice outlined here: https://github.com/voxpupuli/puppet-lint-params_empty_string-check. However, I realize that Nexus expects an empty string...

My apologies for the oversight.

TuningYourCode commented 11 months ago

Thanks, we are always happy about contributions :)

There will be most likely "soon" a release to have all the new features also in the forge package.