puppylinux-woof-CE / woof-CE

woof - the Puppy builder
GNU General Public License v2.0
395 stars 283 forks source link

replace orange icon theme #297

Closed 01micko closed 10 years ago

01micko commented 10 years ago

With the new default icons.. looks nice, still need a few icons

default-icons

01micko commented 10 years ago

Icons needed are, home, chat, paint, draw.. the others are fine, just want to keep it light as an alternative. I made the email version, does the job! My 'draw' effort.. well not so good! Oh, trash also.. but I believe a gtk-delete may do the job.

zigbert commented 10 years ago

Of course the puppy-stock icons should be linked to a builtin icon theme... Doesn't matter if the icons doesn't look perfect, - the icons need a round 2 after things get in-place. As it's look to me, the challenge by switching from raster to vector on the desktop is the pup-event icons. They are 'built' from an icon and the Barry-frame/close-button. Building an svg is easy, but svg does not support to embed another svg file.

Also, the menu needs a couple of new icons as well. We'll get there... The major task is not the icon-theme - but how to get rid of the mini-icons...

01micko commented 10 years ago

The biggest problem is not woof itself but the possibly hundreds of pet packages that rely on those mini-icons for their .desktop files. We will have to come up with some sort of work around for that situation.

zigbert commented 10 years ago

step 1 - get rid of xpm in woof guis (Much is already done) step 2 - change icon in desktop file in ../woof-code/packages-templates (I have started) step 3 - build a more complete collection of svg. step 4 - dir2pet (among others) should not use mini-icons, but the puppy-stock. step 5 - update gtkdialog guis in the packages-templates. I am sure we will find something to improve here. step 6 - ...?

With step 4 in place, we will over time slowly move away from the mini-icons. I will continue to expand the svg collection. It is far from fulfilled. If anyone could look at step 4, it would be great.

01micko commented 10 years ago

Also, please be aware that the templates in woof are only executed when a parent distro's package is used as all pets are supposed to be 'woof ready' ootb. So in my abiword pet for example, the template is not executed. No problem. I'll change the pet. I do have slackware versions of epdfview and gftp, so I'm testing your changes now. I will look at dir2pet.

In the case of seamonkey template, I will have to preserve the original icon in the template. There may be others too.

zigbert commented 10 years ago

I am working on a full set of icons for the desktop/menu. Things take time, but we'll get there. To get this work fully, the icon-switcher has to be updated. In this progress, I suggest:

01micko commented 10 years ago

Define exactly what icons a theme should contain.

Only minimum needed I think

Abandon raster icons

Why? Although I dislike the path /usr/local/lib/X11/bla-bla it should stay for backward compatibility. There are many icon sets out there and users always want to customise. The svg icons convert to png (rsvg) just fine as it is. I don't think raster to svg exists. I did look for it once. There are some buggy "tracing" type programs, no good.

Use unique icons for the menu-categories. (Can be linked to desktop-icons if similar. As jwm scales 'nicely' now, there is no need of 24-pixels icons for menu.)

Ok.

I'm underway with icon_switcher.. will eliminate icon_switcher_cli, call from symlink (code duplification) and also need to change /usr/share/desktop-directories/*.directory files to change the icons.

01micko commented 10 years ago

Ok, it works fine, and images in menu are 48 now. Also need to fix this in 3builddistro then I'll commit the changes.

Also, I don't even think icon_switcher_cli is used anymore, still no harm to have symlink.

zigbert commented 10 years ago

Abandon raster icons This is how my brain works at 3 am. Of course you're right. No problem with png's.

I will focus on the last icons, and update the gtkdialog-code in icon switcher. I am not finished with the package-templates, but will do that after (I have reached R - rxvt). Then there is still more .desktop files in /roofs to change

zigbert commented 10 years ago

I don't think a symlink to icon_switcher_cli is required. Let it go.

Here is the result of a global grep in /usr screenshot_2014-01-02_10 47 40

zigbert commented 10 years ago

done! I haven't found out how to add a symlink (or dir) in github (I am still in web-interface), so would any of you add the new Woof-icon theme from http://meownplanet.net/zigbert/woof_icon_theme.tar.gz

I have fixed the icon-switcher to allow symlinks the same way as files.

The 180 puppy-stock icons are still much smaller than the 50 icons in the flat-orange theme. It is a great feeling to remove something - not only add bloat :)

01micko commented 10 years ago

Cool! So what do we call it? "Standard_icons"? Or something more "catchy"?

I'll add it and name it something for now, we can always change it later.

01micko commented 10 years ago

Oh, I see a problem. The links in the new theme (just downloaded from meownplanet) are absolute. They will have to be relative to work with woof building. no problem, I can fix it.

01micko commented 10 years ago

Yeah, crappy name! I made them relative links, easy enough. That way it doesn't point to the running system. (When in woof).

01micko commented 10 years ago

default-icons 1

:+1:

I like the background crop to give the user a preview in the icon_switcher, very nice touch!

01micko commented 10 years ago

for i in ./StandardSvg/* ;do readlink $i;done ../../../../../share/pixmaps/puppy/package_compressed.svg ../../../../../share/pixmaps/puppy/flashcard.svg ../../../../../share/pixmaps/puppy/chat.svg ../../../../../share/pixmaps/puppy/preferences.svg ../../../../../share/pixmaps/puppy/network.svg ../../../../../share/pixmaps/puppy/terminal.svg ../../../../../share/pixmaps/puppy/calendar.svg ../../../../../share/pixmaps/puppy/draw_vector.svg ../../../../../share/pixmaps/puppy/harddisk.svg ../../../../../share/pixmaps/puppy/edit.svg ../../../../../share/pixmaps/puppy/mail.svg ../../../../../share/pixmaps/puppy/floppy.svg ../../../../../share/pixmaps/puppy/directory.svg ../../../../../share/pixmaps/puppy/game.svg ../../../../../share/pixmaps/puppy/dialog-info.svg ../../../../../share/pixmaps/puppy/home.svg ../../../../../share/pixmaps/puppy/screen_lock.svg ../../../../../share/pixmaps/puppy/multimedia.svg ../../../../../share/pixmaps/puppy/cdrom.svg ../../../../../share/pixmaps/puppy/paint.svg ../../../../../share/pixmaps/puppy/execute.svg ../../../../../share/pixmaps/puppy/package_add.svg ../../../../../share/pixmaps/puppy/puppy_save.svg ../../../../../share/pixmaps/puppy/shutdown.svg ../../../../../share/pixmaps/puppy/spreadsheet.svg ../../../../../share/pixmaps/puppy/trash_empty.svg ../../../../../share/pixmaps/puppy/trash.svg ../../../../../share/pixmaps/puppy/harddisk_usb.svg ../../../../../share/pixmaps/puppy/module.svg ../../../../../share/pixmaps/puppy/write.svg ../../../../../share/pixmaps/puppy/internet.svg ../../../../../share/pixmaps/puppy/desktop.svg

All there now.

01micko commented 10 years ago

Good news.. they work in woof build.. and come as the default first choice :+1:

A few bugs at my end to sort and I'll post some delta files. Closing this issue, but you can still comment here.

zigbert commented 10 years ago

Thank you Mick. I am sorry for the symlink trouble. - I am learning.

The theme is not glorious, but it's ok, and a start. Let's modify when we get inspired.

On your screenshot, it looks like you have modified the draw_vector.svg icon. Please test the icons on different backgrounds. One single gray line disappears on a similar background color.

01micko commented 10 years ago

Symlinks were not a bother. It's just how woof works, everything needs to be relative because it is built relative, and partly in chroot, which more or less makes a different directory for "/".

If this theme is not glorious then I shall not pass comment on the orange one!

I didn't modify any icons, however the screeny is on my build system, not the woofed one so I may not have copied over all icons correctly. The woofed build will have all the icons as you committed. As you said, we can tweak when we feel inspired. I think it's great as it is. A build will go up soon.

Thanks very much for your work!

01micko commented 10 years ago

screenshot_2014-01-03_201244

That's the alpha .. uploading deltas now.