puppylinux-woof-CE / woof-CE

woof - the Puppy builder
GNU General Public License v2.0
382 stars 273 forks source link

Add tldr-py and btop to Jammy64 #4221

Closed lakshayrohila closed 5 months ago

lakshayrohila commented 5 months ago

This commit adds tldr-py (petbuild) and btop to Jammy64 on Clarity's request here.

It also introduces two petbuilds: tldr-py and python3-shtab (the latter being a dependency of tldr-py petbuild).

I wanted to use tldr-py instead of the regular tldr because the package tldr is quite large as it has dependencies such as git. There is also a tldr-py Ubuntu package, but in Jammy, this one was quite old and, IMHO, not very user-friendly.

python3-shtab petbuild was required to be added because it is not available in Ubuntu Jammy's repos (it started with Ubuntu Lunar).

lakshayrohila commented 5 months ago

@peabee, @dimkr, please review.

peabee commented 5 months ago

Not sure they're really needed..... but if only JammyPup64 is affected - no objection.

lakshayrohila commented 5 months ago

Not sure they're really needed..... but if only JammyPup64 is affected - no objection.

Not really required - Just few additional features (we are still trying to build an official Jammy64, right?)

dimkr commented 5 months ago

I'd strongly recommend you not to add petbuilds for Python packages, unless you're 100% committed to maintaining them in the long term. They tend to be sensitive to the Python version. In this particular case, I wouldn't do this because I think the benefit is not worth it - documentation beyond man pages is easy to find online and I think the extra size and maintenance cost is not worth it.

lakshayrohila commented 5 months ago

I'd strongly recommend you not to add petbuilds for Python packages, unless you're 100% committed to maintaining them in the long term.

Actually, 0% committed for maintenance :-1:.

They tend to be sensitive to the Python version. In this particular case, I wouldn't do this because I think the benefit is not worth it - documentation beyond man pages is easy to find online and I think the extra size and maintenance cost is not worth it.

Well, I also agree with this. Thanks for the information and the advice!

I'll close the PR.