puppylinux-woof-CE / woof-CE

woof - the Puppy builder
GNU General Public License v2.0
382 stars 273 forks source link

Sync x-www-browser with defaultbrowser when using Palemoon petbuild #4240

Closed lakshayrohila closed 5 months ago

lakshayrohila commented 5 months ago

Use update-alternatives command to sync by default, /usr/bin/x-www-browser with /usr/local/bin/defaultbrowser.

Specifically, this is required in epdfview since it uses x-www-browser by default to open URL links.

@dimkr, @peabee please review.

dimkr commented 5 months ago

In Vanilla Dpup I went for a different solution, defaultbrowser runs x-www-browser. You set the default browser the Debian way, not the Puppy way.

lakshayrohila commented 5 months ago

In Vanilla Dpup I went for a different solution, defaultbrowser runs x-www-browser. You set the default browser the Debian way, not the Puppy way.

@dimkr, thanks for the suggestion! I have re-implemented this fix to your suggestion. Please re-review.

dimkr commented 5 months ago

I think it would be cleaner to change the palemoon petbuild, so it makes x-www-browser run palemoon, then sets defaultbrowser to x-www-browser, only in Debian or Ubuntu based build.

https://github.com/puppylinux-woof-CE/woof-CE/blob/4c8a372cd9bec68d687d2f8018e7121d5563efca/woof-code/packages-templates/firefox_FIXUPHACK#L87

lakshayrohila commented 5 months ago

I think it would be cleaner to change the palemoon petbuild, so it makes x-www-browser run palemoon, then sets defaultbrowser to x-www-browser, only in Debian or Ubuntu based build.

https://github.com/puppylinux-woof-CE/woof-CE/blob/4c8a372cd9bec68d687d2f8018e7121d5563efca/woof-code/packages-templates/firefox_FIXUPHACK#L87

@dimkr, done, please review.


One question: is pinstall.sh run in chmod? Reading some lines of code in 3builddistro, I don't think it does. Then I'll have to update this commit.

lakshayrohila commented 5 months ago

Looks good to me - again, I have no merge rights

But your reviews are great and helpful! Thanks :+1:!

@peabee, please merge this if you have no objections.

peabee commented 5 months ago

Looks good to me - again, I have no merge rights

@puppylinux-woof-CE/members - please note that this is not a sustainable situation