If using an external monitor, turn off the internal display on lid close

[dimkr]

This PR makes Puppy: 1) Turn off the internal display and disable suspend on lid close, if there's at least one external monitor 2) Turn on the internal display on lid open, in case the laptop was suspended while connected to an external monitor, then disconnected and opened

[peabee]

Ready to merge? Still seems to be being worked on?

[dimkr]

Ready to merge?

Up to you. Puppy always had this weird behavior of not suspending on lid close at all or suspending on lid close even when connected to an external monitor, so I wonder why nobody is either complaining about this or commenting here.

Still seems to be being worked on?

Only a bug fix after 2w without activity 😸

EDIT: and another one today

[peabee]

I guess not that many people use Puppy in that configuration - I certainly don't.... more likely to be users on the forum than here..... MochiMoppel seems to be testing but is not on Github? I will wait until you confirm that all bugs are squashed and tested.

[dimkr]

I guess not that many people use Puppy in that configuration

Puppy doesn't have a display settings panel where you can move and rotate your displays, I bet very few people actually use Puppy with multiple monitors, and those that do just use the default arrangement.

I will wait until you confirm that all bugs are squashed and tested.

Up to you, but don't hold your breath: without a display settings panel and a daemon that constantly re-applies the user's chosen settings when monitors are connected and disconnected, there's no way to make Puppy handle multiple monitors to the same standard as GNOME or KDE. This PR will never be 'ready'.

Wayland has kanshi, wdisplays and other tools, so it would be best to adopt one of these instead of building an in-house solution just for Puppy. And developing a solution for X.Org is a waste of time at this point.

This PR is merely a 80/20 solution for the use case of people who use a laptop with external monitor(s) and want to close the lid. It will mess up the display settings of people who somehow configure their monitors, once they reopen the lid, which is practically nobody (again, because Puppy doesn't have a display settings panel: those who configure their monitors probably have their ugly xrandr startup script).

[peabee]

I think I am unsure whether this is a PR that you would like to see applied to all future Pup builds or whether it is a private optional PR just to be applied to your builds. Can it be supplied as an optional add-on (.pet?)? It could then be tested more widely on the forum?

[dimkr]

https://forum.puppylinux.com/viewtopic.php?p=122436

[peabee]

??

[peabee]

Ready to merge?

[dimkr]

Ready to merge?

Up to you, I haven't changed anything since May 11 and I think it's an improvement over the current state (although it's not perfect)

[peabee]

I have no view or need.