puppylinux-woof-CE / woof-CE

woof - the Puppy builder
GNU General Public License v2.0
397 stars 285 forks source link

PPM: Code refinement, integrates web-browser advice window #4293

Closed rserwin1 closed 5 months ago

rserwin1 commented 5 months ago

Finalizes PPM updates to v2.5 with code cleanup, unnecessary-message reduction and shellcheck resolutions.

peabee commented 5 months ago

Addition of ppm_advice.sh This is specific to certain builds and also relies on lx_sfs_mgr being present (which is also specific to a subset of the builds). Not sure this should be a PPM feature?

There is a typo at line 4: web- should be get-

peabee commented 5 months ago

Maybe ppm should just check if ppm_advice.sh exists and call it if it does - then each build can decide whether they want ppm_advice.sh and what they want it to display......

techrockedge commented 5 months ago

that does sound interesting