puppylpg / oddish

Crawl csgo skin info from `buff.163.com` and steam, then find the most suitable one to buy from the former and to sell to the latter.
https://puppylpg.github.io/2019/12/07/python-crawler-buff-optimaze/
GNU General Public License v3.0
323 stars 81 forks source link

Selectable asyncio #67

Closed zzwk closed 3 years ago

zzwk commented 3 years ago

要增加/修改的功能/修复的bug

async的bug修复,cache的修复,添加输出结果中buff链接,提取重复方法。

相关issue

改动内容描述

把cache读取导致session超时的bug修了(已测试),suggestion添加了buff链接输出,之前重复的方法提取出来了。此外修了个导致warning的小bug。

核验信息

核验以下信息,已完成的项记得补全check box(中括号里填'x'):

新代码效果截屏(建议)

puppylpg commented 3 years ago

其他我没问题了,上面的稍微改一下吧,然后我就合了

测了一下确实问题不存在了。但是这个确实很迷,并没有感觉自己设置一个timeout和client本身的默认timeout有什么区别:

# 5 Minute default read timeout
DEFAULT_TIMEOUT = ClientTimeout(total=5 * 60)
puppylpg commented 3 years ago

66

puppylpg commented 3 years ago

加一下changelog吧

68

zzwk commented 3 years ago

不好意思啊,还麻烦你改代码、加changelog,这几天我有点忙不过来了

puppylpg commented 3 years ago

不好意思啊,还麻烦你改代码、加changelog,这几天我有点忙不过来了

小事儿,急着合我就直接改了。忙成狗还抽空发个pr,辛苦了 😺