pupsnow / as3-commons

Automatically exported from code.google.com/p/as3-commons
1 stars 0 forks source link

Allow the optional use of "label" in MonsterDebuggerTargets #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently the "label" property of the MonsterDebuggerTarget is not beeing used. 
Make it optionally available to be used in the MonsterDebuggerTargets.

Original issue reported on code.google.com by mastakan...@gmail.com on 5 Sep 2011 at 4:24

GoogleCodeExporter commented 9 years ago
As the person who raised this, I would say a good candidate for this is to 
simply pass the log level name to the label property (also has the advantage of 
being a one second fix :)). Monster debugger doesn't really use the concept of 
"DEBUG", "INFO" etc. so once you start logging you have no way to use the built 
in filtering to sort through the various log levels.   

Original comment by BurntPro...@gmail.com on 5 Sep 2011 at 6:55

GoogleCodeExporter commented 9 years ago
What a lightbulb event! Thanks for pointing that out! (Idiosyncrasies hide 
around many corners these days). What about using formatter:

mdTarget.label = "{logLevel}"; // That would be the default

good idea?

Original comment by mastakan...@gmail.com on 6 Sep 2011 at 1:22

GoogleCodeExporter commented 9 years ago
Well in the MonsterDebugger3TraceTarget class I changed line 113 form 

MonsterDebugger.trace( name, message, person, ""/* Label is not supported */, 
_colors[level], _depth );

to

MonsterDebugger.trace( name, message, person, levelToName(level), 
_colors[level], _depth );

Seemed the most straight forward way to do it. 

Original comment by BurntPro...@gmail.com on 6 Sep 2011 at 7:11

GoogleCodeExporter commented 9 years ago
Added the changes in the trunk: See here: 
http://code.google.com/p/as3-commons/source/browse/trunk/as3-commons-logging/src
/main/actionscript/org/as3commons/logging/setup/target/MonsterDebugger3TraceTarg
et.as

Original comment by mastakan...@gmail.com on 9 Sep 2011 at 4:29