search

pupudu / window-table

Windowing Table for React based on React Window
https://window-table.netlify.com/
170 stars 13 forks source link

Should we support Event Handler in this library? #20

Closed onesinus closed 5 years ago

onesinus commented 5 years ago

The table works well since i follow the documentation https://window-table.now.sh/

But for now i'm thinking to add some event handler in table's rows such as onClick handler

as far as i see the documentation i don't get the event handler, is that possible to add some event with this module?

Thanks in advance

pupudu commented 5 years ago

Hi @onesinus Thank you for creating this issue. Adding event handlers are supported even as of now, though it may not be very clear at first. A TL;DR is, you can do this by supplying custom components as Row, Column, etc.

I will quickly add a new guide to explain how this can be done with minimal effort.

pupudu commented 5 years ago

@onesinus I've added a new comprehensive guide on how we can leverage the customizability of this library to add event listeners to the rows.

Let me know if you need any other clarifications.

Thanks.

pupudu commented 5 years ago

Also, would appreciate it if you can star the repo to support our growth. Thanks!

onesinus commented 5 years ago

I try onClick row and it works perfectly, My star exactly for you :)