search

pupudu / window-table

Windowing Table for React based on React Window
https://window-table.netlify.com/
170 stars 13 forks source link

Couldn't hide border of the last child from thead #26

Closed 18601673727 closed 5 years ago

18601673727 commented 5 years ago

Hi, Thanks for bring us such a nice lib! Really helpful but there seems to be a tiny flaw:

.table-header-cell, .table-cell {
    padding: 15px;
    border-bottom: 4px solid var(--light);
    border-right: 4px solid var(--light);

    &:last-child {
      border-right: 0;
    }
}

Result: image

pupudu commented 5 years ago

Hi there, Thank you for creating this issue.

Could you tell me a bit more about this issue? Does it happen only for the text columns?

Or is it possible for you to reproduce this in a demo codesandbox or something? Would be pretty easy to fix it if you can do that.

Cheers.

18601673727 commented 5 years ago

Hi @pupudu,

Of course, here you go: https://codesandbox.io/embed/thirsty-dewdney-u3pro

pupudu commented 5 years ago

Hi @18601673727 This issue has been fixed with v0.8.11 https://codesandbox.io/embed/wild-smoke-eof57

Thanks again for opening this issue