pupudu / window-table

Windowing Table for React based on React Window
https://window-table.netlify.com/
170 stars 13 forks source link

Update types.tsx to match implementation #48

Closed Dashue closed 4 years ago

Dashue commented 4 years ago

rowClassName can be string or function.

Currently in the latest verision, typescript prevents us to define rowClassName as laid out in the examples: rowClassName={index => (index % 2 === 0 ? 'even-row' : 'odd-row')}

Dashue commented 4 years ago

@pupudu Got a minute to review this change? I've did the update locally to develop but now when pushing I can't modify node_modules on azure.

Would be great to get this in and a new release cut if possible

pupudu commented 4 years ago

Hi @Dashue Thanks for submitting this change. Apologies for the silence in the past few days, as I was away from my computer. Will get back to all the questions now

pupudu commented 4 years ago

Just published 0.10.6 🎉

Dashue commented 4 years ago

Yeah buddy!