search

pupudu / window-table

Windowing Table for React based on React Window
https://window-table.netlify.com/
170 stars 13 forks source link

add tableOuterRef and tableOuterElementType props #55

Closed hipstersmoothie closed 4 years ago

hipstersmoothie commented 4 years ago

Add props to add ref and control tag used to create outer div. You need this div to detect if react-window is scrolling.

hipstersmoothie commented 4 years ago

I'm not sure this one got released correctly

hipstersmoothie commented 4 years ago

Oh nvm it hasn't been published yet! I though you had some sort of automation set up, turns out you were just quick yesterday. If you need any help with that I might know a thing or two https://github.com/intuit/auto

pupudu commented 4 years ago

@hipstersmoothie exactly mate. I was thinking of setting up semantic-release or lerna just to achieve this. But auto looks nice as well. Having used argocd extensively, I can definitely trust intuit software. Feel free to make a PR if you have the time. If not, I'll give a go soon.

Also, I added you as a contributor to the project yesterday.

Thanks mate. I just manually published the next release.