search

pupunzi / jquery.mb.YTPlayer

use a custom yutube player for a video as background on jQuery framework
https://pupunzi.com/mb.components/mb.YTPlayer/demo/demo.html
1.33k stars 429 forks source link

Volume slider not working on chrome #208

Open geesen opened 8 years ago

geesen commented 8 years ago

The volume slider from the default controls is not working on Chrome. All other controls like play, mute, the time-slider etc. works.

For example: http://pupunzi.com/mb.components/mb.YTPlayer/demo/demo_as_player.html Firefox and Edge is working, but not Chrome.

chrome version: 53.0.2785.116 m (current version) os: windows 10

Can someone confirm this?

pupunzi commented 8 years ago

Hi, Just tested on Chrome both on a mac OSX and on a Windows 10 and it's working fine. do you have any error on the javascript console? or any Chrome plugin that can interfere with the component?

geesen commented 8 years ago

Hi,

There are no errors and I disabled all extensions and also tested it in incognito-mode - it is not working.

I also tried to debug, but I could not figure out what should normally be called if I click on the slider... Am I right that normally the callback of the volumeBar.simpleSlider would be called if I click on the volume slider bar?

If I use the dev-tools to switch to a "touch device", the slider is working. So, it seems that there are problems with the click/mousedown event from the simpleSlider. Touchstart is working and calls the simpleSlider callback.

I don't know, if it is the actual cause, but there was a change in chrome: https://developers.google.com/web/updates/2016/06/chrome-52-deprecations#remove-non-primary-button-click-event

geesen commented 8 years ago

Some more details:

Looking at this answers/discussions it seems that there is no solution that works for every system/browser: http://stackoverflow.com/questions/3974827/detecting-touch-screen-devices-with-javascript

pupunzi commented 8 years ago

I'll see how to fix that... Chrome is detecting your computer as a touch device that's why it doesn't work.

kinsbrunner commented 7 years ago

I am facing the same issue and also, tried to set showControls to false but they are still being shown :)

I will try to see whether I found a solution for this :)

fraternl commented 5 years ago

I have no problem with the volume on a desktop, but on a touch device it seems it's not working. Initially I had a low volume on the flicks on my site, but now I have opted for a volume of 90%

I would prefer to have no volume slider at all (optionally) on a mobile device as I would rather let the user use the volume buttons. In that case the mute / unmute could then stay. This would mean less icons and a cleaner interface.

fraternl commented 5 years ago

Here https://github.com/pupunzi/jquery.mb.YTPlayer/issues/431 I'm suggesting to drop both YT control and slider whenever the interface doesn't have enough room to properly inter space these controls. I think that also would improve the user friendliness.