puranjayjain / language-liquid

Liquid language support for Atom.
MIT License
28 stars 23 forks source link

Duplicate key 'sort' in snippets/language-liquid.cson #38

Closed raphinesse closed 6 years ago

raphinesse commented 6 years ago

Using v0.6.0 of this package in Atom 1.26.0-beta0. On startup, I get the following error:

Failed to load snippets from '~/.atom/packages/language-liquid/snippets/language-liquid.cson' ~/.atom/packages/language-liquid/snippets/language-liquid.cson: Duplicate key 'sort'

imshawin commented 6 years ago

The same problem with 1.25.0 version.

niedfelj commented 6 years ago

@puranjayjain Are you managing this project or not? This code doesn't load in Atom anymore

lizbanach commented 6 years ago

I have the same issue.

sixcupsofcoffee commented 6 years ago

Syntax highlighting still works, it's just the snippets file that won't load.

I submitted a pull request to fix this, but I don't know if it'll ever get merged if @puranjayjain has become inactive. The branch to fix it is here, you just need to manually install it in ~/.atom/packages/

puranjayjain commented 6 years ago

@niedfelj @erbanach @sixcupsofcoffee I have not been active on Github lately. But will try my best to get this resolved asap.

Ya7yaL commented 6 years ago

I have the same issue on same Atom build. I get this error message :

Failed to load snippets from '/Users/yann/.atom/packages/language-liquid/snippets/language-liquid.cson'
/Users/yann/.atom/packages/language-liquid/snippets/language-liquid.cson: Duplicate key 'sort'
sixcupsofcoffee commented 6 years ago

There is a (temporary, possibly) fix merged in here, but @puranjayjain needs to update the version here so Atom will trigger an update. You can also download this repo and install it to Atom manually.

Ya7yaL commented 6 years ago

Thank you @sixcupsofcoffee, I pasted the master repo in ~/.atom/packages , no more error.

jmsfwk commented 6 years ago

This is fixed in master but the new version need to be published.

vaevictis commented 6 years ago

I've just updated the file manually. Not ideal for long term, but for now, it got rid of the alert box each time I'd load atom.

sixcupsofcoffee commented 6 years ago

Yeah, the version hasnโ€™t been updated yet on here so it wonโ€™t trigger an update in Atom.

flaviocamilo commented 6 years ago

A tip to automatically install from the master branch (so you don't have to clone and move): apm i puranjayjain/language-liquid.

ileitch commented 6 years ago

@puranjayjain can you tag 0.6.1 please so that this can be resolved? Thank you ๐Ÿ˜ƒ

puranjayjain commented 6 years ago

I apologize for the delay, Will do it tonight

ashfame commented 6 years ago

@puranjayjain Gentle Reminder! Please tag 0.6.1 :)

jlgabriel commented 6 years ago

Another vote for the update to 0.6.1, thanks for the Atom package!

bl4ck5un commented 6 years ago

same issue here. would be great to see a fix.

michaelmyc commented 6 years ago

Voting for the update to 0.6.1! Thanks!

puranjayjain commented 6 years ago

Bumped to 0.7.0 to accommodate multiple fixes ๐Ÿป ๐ŸŽ‰ ๐ŸŽˆ