puranjayjain / react-materialui-notifications

Spec compliant notifications for react and material ui users
https://puranjayjain.github.io/react-materialui-notifications/
MIT License
251 stars 36 forks source link

Cant close notifications #125

Closed jrogatis closed 7 years ago

jrogatis commented 7 years ago

i cant close the notification .. I try both the top right close button and a close function at a dismiss button trying set the open prop.

material-ui ver 0.17.1 react 15.4.1

showNotification(msgTitle, msgAdditionalText, msgOverflowText) { ReactMaterialUiNotifications.showNotification({ title: msgTitle, additionalText: msgAdditionalText, icon: , iconBadgeColor: '006400', overflowText: msgOverflowText, timestamp: moment().format('h:mm A'), }); } <ReactMaterialUiNotifications desktop transitionName={{ leave: 'dummy', leaveActive: 'fadeOut', appear: 'dummy', appearActive: 'zoomInUp', }} transitionAppear transitionLeave />

puranjayjain commented 7 years ago

@jrogatis thanks for reporting it. It seems we already have a solution, the project needs to be migrated to react version newer, which is causing the problem.

jrogatis commented 7 years ago

can i help at any way ? I really like your component and if you need some help please let me know !

puranjayjain commented 7 years ago

I'm trying to solve it using key fix which someone pointed out in an earlier issue discussion. I'll try to fix it on my end, if not possible will definitely ask for your help via a Pull request.

puranjayjain commented 7 years ago

I made some changes and have pushed a commit can you do the following :-

  1. download a copy of the latest commit
  2. run npm install or yarn install
  3. execute gulp run or use the gulp run.bat file
  4. test the demo that opens up and tell me the results
jrogatis commented 7 years ago

demo works ! let me try using the component at my project now! Tks!

jrogatis commented 7 years ago

oh no... its not working at my project... no messages... just dons't close when i click the x... Anything that i can do help ?

puranjayjain commented 7 years ago

There must be something that you might be doing wrong in your implementation. If it is open source I can take a look at it.

jrogatis commented 7 years ago

its a no profit project for Free Code Camp this is the link for the branch https://github.com/jrogatis/LetsMeet/tree/material-ui_implement Really appreciate any help ! Your component will be a perfect match since we use material-ui !

Meesam commented 7 years ago

can't close notification.

jrogatis commented 7 years ago

I figure out what was causing the issue ... After you delete the notification at the notifications array you need to use a forceUpdate to re render the component... since you are not using the notifications array as a state controller.

puranjayjain commented 7 years ago

can you make a pull request to fix it? It would be a really helpful update

jrogatis commented 7 years ago

ok i will try today

imlooke commented 7 years ago

I can't close notification in my program, but I figure out the issue in my program that I don't add the animation class fadeOut and zoomInUp.And it worked!Hope useful.

da-poodle commented 7 years ago

Same case here as imlooke, notifications where not disapearing, then removed transitions and it worked fine.

puranjayjain commented 7 years ago

fixed in PR #129