puranjayjain / react-materialui-notifications

Spec compliant notifications for react and material ui users

https://puranjayjain.github.io/react-materialui-notifications/

MIT License

251 stars 36 forks source link

Enhancement : Add tests and coverage #130

Open rishacha opened 7 years ago

rishacha commented 7 years ago

Enhancement : Add tests and coverage

I was just looking through the code and thought it would be nice to add in some tests and have some coverage in. How's the thought @puranjayjain ?

[x] Search the currently opened issues and past issues before posting a new one.
[x] Escalate issues by making a reaction of :+1: at the first comment on the issue (the issue author's)
[x] Be clear and try to open an issue with one problem at a time (open multiple issues if you have multiple problems)

puranjayjain commented 7 years ago

I agree there should be. Care to start a PR?

rishacha commented 7 years ago

Just saw this :stuck_out_tongue: . Give me some time to look into this.

EDIT : Do we need to commit the build folder? I made a minor change and found that I had this diff

$ git diff --stat d4747eaf3d9bacdd4a16e2479ba76ac7469027df..69726ce67c3df902c76dde27c254280032a0a7b6
 build/app.js    | 8200 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------
 src/app/Main.js |    2 +-
 2 files changed, 4035 insertions(+), 4167 deletions(-)