search

purarue / google_takeout_parser

A library/CLI tool to parse data out of your Google Takeout (History, Activity, Youtube, Locations, etc...)
https://pypi.org/project/google-takeout-parser/
MIT License
82 stars 14 forks source link

Parse PlaceVisits #35

Closed ryanbateman closed 1 year ago

ryanbateman commented 2 years ago

This PR adds the ability to parse basic PlaceVisits out of the Takeout Semantic Location History (which contains a person's Maps timeline / location history over time.) While the Semantic Location History JSON has timelineObjects as the root list, this PR does not attempt to add parsing these out, as this would require also parsing out ActivitySegments. As such, this does not fully address Issue #16. A future PR could amend and add to this approach to do so.

ryanbateman commented 2 years ago

Thanks, @seanbreckenridge - I'll take a look and try to address them. I'm not particularly a Python developer, so it may be somewhat slow, but I really appreciate the depth and thoroughness of input. Cheers!

purarue commented 2 years ago

All good. Feel free to comment if you're stuck somewhere. If you're really stuck at some point I'm also happy to take over and work on this to integrate the model into the larger project - parsing the JSON always the difficult part

Am currently moving so apologies if there are delays on my end

On Mon, Oct 24, 2022, 2:16 PM Ryan Bateman @.***> wrote:

Thanks, @seanbreckenridge https://github.com/seanbreckenridge - I'll take a look and try to address them. I'm not particularly a Python developer, so it may be somewhat slow, but I really appreciate the depth and thoroughness of input. Cheers!

— Reply to this email directly, view it on GitHub https://github.com/seanbreckenridge/google_takeout_parser/pull/35#issuecomment-1289627110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3RO522L7SD5ENYCFYOZL3WE34CBANCNFSM6AAAAAARMHQCD4 . You are receiving this because you were mentioned.Message ID: @.***>

purarue commented 1 year ago

Hey, @ryanbateman, hope you don't mind, went ahead and made those fixes/added a test and pushed to master

purarue commented 1 year ago

You can see the model here, will push a new release to pypi in a few minutes

ryanbateman commented 1 year ago

@seanbreckenridge Not at all - I had a fully implementation set up for update but kept running into errors that I couldn't (with my basic Python knowledge) distinguish as a result of my data or my implementation, so this is great - a reference implementation!