semantic locaion history parser: handle missing placeId and placeConfidence

purarue / google_takeout_parser

A library/CLI tool to parse data out of your Google Takeout (History, Activity, Youtube, Locations, etc...)

https://pypi.org/project/google-takeout-parser/

MIT License

82 stars 14 forks source link

semantic locaion history parser: handle missing placeId and placeConfidence #50

Closed karlicoss closed 1 year ago

karlicoss commented 1 year ago

placeId may be missing for even recent places, I think that happens when google can't guess it
placeConfidence seems to be missing historically, probably makes sense to make it optional?

karlicoss commented 1 year ago

Oh, another bunch of warnings I noticed is latitudeE7 missing on about 10 semantic entries historically. Happy to make it a bit more defensive too and just ignore if coordinates are missing if you think it makes sense

purarue commented 1 year ago

Thanks, yeah making optional sounds good

yeah, if its missing latlon I think its worth just sending a logger.debug and continueing, I dont think its worth parsing info that doesnt have the location

karlicoss commented 1 year ago

done, ended up even a bit cleaner I'm using an editable local setup and might PR a few more minor patches later so no need to rush in releasing after merging!