search

purcell / airspeed

A lightweight Python template engine compatible with Velocity, used in OpenStack
Other
91 stars 37 forks source link

Tests now work with Python 3.x #41

Closed thorsteneb closed 5 years ago

thorsteneb commented 5 years ago

Use imp or importlib for reload depending on Python version Replace all assertEquals with assertEqual Replace assert_ with assertTrue

purcell commented 5 years ago

Thanks, but please can you clarify? The tests were already working with Python 3.x, e.g. see https://travis-ci.org/purcell/airspeed/builds/601039003

thorsteneb commented 5 years ago

reload() needed a change for Python 3.x, it requires importlib from 3.4 on. As-is, the test module was failing on the reload() part. See also https://www.geeksforgeeks.org/reloading-modules-python/ The other changes were made to stop deprecation warnings.

From: Steve Purcell notifications@github.com Sent: Thursday, November 14, 2019 8:34 PM To: purcell/airspeed airspeed@noreply.github.com Cc: Thorsten Behrens tbehrens@outlook.com; Author author@noreply.github.com Subject: Re: [purcell/airspeed] Tests now work with Python 3.x (#41)

Thanks, but please can you clarify? The tests were already working with Python 3.x, e.g. see https://travis-ci.org/purcell/airspeed/builds/601039003https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fpurcell%2Fairspeed%2Fbuilds%2F601039003&data=02%7C01%7C%7C8df7b1466ef640ad8e8708d7696bf0d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637093784625957926&sdata=Vahm%2FP%2Bb3oFf5X3X5DdkoOO8RIhrYJfSw6ftgcLFAJc%3D&reserved=0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpurcell%2Fairspeed%2Fpull%2F41%3Femail_source%3Dnotifications%26email_token%3DAAED726Z43HE4FG5QMZ2SEDQTX4BZA5CNFSM4JNPCWYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEED7ERQ%23issuecomment-554168902&data=02%7C01%7C%7C8df7b1466ef640ad8e8708d7696bf0d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637093784625967931&sdata=H76SVdhoXeTndWsC%2FQCLOVAqjb5TlSgy6fLmCFquz1k%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAED72YWRTWEIIVJ7KJSWTLQTX4BZANCNFSM4JNPCWYA&data=02%7C01%7C%7C8df7b1466ef640ad8e8708d7696bf0d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637093784625977942&sdata=%2FGYJ7HbH6m33P9hAbb2suMFgyMPBWIUKmry%2BTkDrLsw%3D&reserved=0.

purcell commented 5 years ago

Thanks, it's hard to tell, though, because the diff is just one big delete/add chunk spanning the whole file. Did you change line endings, or indentation, or something?

thorsteneb commented 5 years ago

I noticed that. Line ending is entirely possible. It shouldn’t have, should all stay LF ... and I can check.

Yours

Thorsten Behrens (Sent from mobile)

From: Steve Purcell notifications@github.com Sent: Friday, November 15, 2019 7:24:52 PM To: purcell/airspeed airspeed@noreply.github.com Cc: Thorsten Behrens tbehrens@outlook.com; Author author@noreply.github.com Subject: Re: [purcell/airspeed] Tests now work with Python 3.x (#41)

Thanks, it's hard to tell, though, because the file is just one big diff. Did you change line endings, or indentation, or something?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpurcell%2Fairspeed%2Fpull%2F41%3Femail_source%3Dnotifications%26email_token%3DAAED72YSCR4SBVTUJHCA4ZLQT44VJA5CNFSM4JNPCWYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHDXFQ%23issuecomment-554580886&data=02%7C01%7C%7C3398efbd79074417003e08d76a2b660e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637094606928331852&sdata=9pbxg2SmOvqgT9oR%2B%2BbvD94QGFHNdbaG0gzH2NcgmSM%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAED724Y2IRFZGFLYOL26A3QT44VJANCNFSM4JNPCWYA&data=02%7C01%7C%7C3398efbd79074417003e08d76a2b660e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637094606928341863&sdata=P3fcfQsJ9GWozjXUj63%2FLthP6nK%2FKZactpOKDY%2BHef8%3D&reserved=0.

purcell commented 5 years ago

Yes, the line endings changed to DOS. I've fixed that up, squashed the commit, and merged in 7cb5723 - thanks!

thorsteneb commented 5 years ago

Thank you. I’ll take a look at core.autocrlf, that should not have happened.

In the process I learned about .gitattributes “* text=auto”, as a way to set that for the project.

All the best Thorsten