search

purcell / airspeed

A lightweight Python template engine compatible with Velocity, used in OpenStack
Other
91 stars 37 forks source link

replace nose testing framework #59

Closed fmoessbauer closed 2 years ago

fmoessbauer commented 2 years ago

Hi,

I'm a maintainer of the Debian packaging of the airspeed project.

The airspeed project internally uses the nose testing framework, which is not maintained since 2015. Are there plans to replace that framework?

For details, see:

purcell commented 2 years ago

There are no plans, but I'm open to it. The tests are just unittest.py tests anyway (which framework I originally wrote 20+ years ago!).

purcell commented 2 years ago

Also worth noting that nose is only included in tests_require, not install_requires. I'm surprised if the dev dependencies get included in the Debian package.

purcell commented 2 years ago

I made a corresponding change, if you'd like to check it out. Presumably it would need to be released to be useful to you?

fmoessbauer commented 2 years ago

Thanks for the immediate response. That was quick!

Also worth noting that nose is only included in tests_require, not install_requires. I'm surprised if the dev dependencies get included in the Debian package.

The "binary package" of course does not depend on the -dev dependencies. But the "source package" (which is used to generate the binary package) depends on the -dev deps, as well as the testing dependencies. By that, we can run the tests at build time and detect issues early. If you are interested in the details, have a look at [1].

I made a corresponding change, if you'd like to check it out. Presumably it would need to be released to be useful to you?

The patch looks good. I'll give it a try tomorrow and report back. Then we would need a release to fix the issue on our side. BTW: you removed the coverage dep as well.

fmoessbauer commented 2 years ago

I can confirm that this works. Could you please cut a new (patch) release?

purcell commented 2 years ago

BTW: you removed the coverage dep as well.

Yeah, that's fine — folks can add it in and incorporate it via tox or manual installation if they like. It might get added back in later if I decide to add proper CI here.

Could you please cut a new (patch) release?

Done: 0.5.20.

fmoessbauer commented 2 years ago

The new release is now uploaded to and accepted in Debian unstable. Thanks!