search

purcell / color-theme-sanityinc-solarized

A pair of Emacs color themes based on Ethan Schoonover's 'solarized' theme
83 stars 20 forks source link

Solarized colors for Term mode and Eshell #7

Closed ozanmakes closed 12 years ago

ozanmakes commented 12 years ago

Eshell bits are from Greg Pfeil's version

I'm not sure if Term mode (and ansi-term, multi-term etc.) is supposed to use ansi-color but I needed these additions.

purcell commented 12 years ago

Thanks. Sorry for the delay; I've merged these changes, but I half wonder whether "black" should be displayed as white when the theme has a dark background... :-)

ozanmakes commented 12 years ago

@purcell: No problem, thanks for merging them in. I thought about that and decided to go this way since term-color-* correspond to ansi colors (not foreground, background etc.) and official colors for iTerm2 doesn't make this distinction. I haven't encountered a problem yet but please change it if you think it is wrong.

purcell commented 12 years ago

No, that's fine -- you've obviously thought about it more than me, so let's wait and see if anyone reports an issue. :-)