search

purcell / emacs.d

An Emacs configuration bundle with batteries included
BSD 2-Clause "Simplified" License
6.84k stars 2.05k forks source link

selectrum change the default minibuffer height #773

Closed Eason0210 closed 3 years ago

Eason0210 commented 3 years ago

Hi @purcell ,

With the latest version of selectrum, when we useC-x, bor M-x , the height of minibuffer will only show one candidate.
it can be change back to old behavior by below setting :

  (setq-default selectrum-fix-vertical-window-height t)

image

OS: Arch Linux, Emacs 28.0.50/ Emacs 28.0.50 native-comp OS: Windows 10 20H2 , Emacs 28.0.50 native-comp

ctrl2wei commented 3 years ago

Try to set marginalia-align-offset. I rely on this to solve this problem.

Eason0210 commented 3 years ago

Try to set marginalia-align-offset. I rely on this to solve this problem.

Thanks, It seems this problem is not from selectrum only. Because, it works well on my Macbook( big sur) and other set of computer with Windows 10 .

ps : on my site, (setq-default marginalia-align-offset 1) can fix issue on C-x, b and M-x, but can't fix issue on C-h, v.
(setq-default selectrum-fix-vertical-window-height t) can fix all the issues.

purcell commented 3 years ago

This is actually an upstream bug

https://github.com/raxod502/selectrum/issues/435

purcell commented 3 years ago

I'll probably commit the workaround for now, but it's not ideal, and I've been chasing up the issue for a few days.

Eason0210 commented 3 years ago

I close this issue, since we have switched to vertico.

purcell commented 3 years ago

Ah, true, thanks.