search

purcell / emacs.d

An Emacs configuration bundle with batteries included
BSD 2-Clause "Simplified" License
6.84k stars 2.05k forks source link

Convert version string into a list of integers #805

Closed demokn closed 2 years ago

demokn commented 2 years ago

https://github.com/purcell/emacs.d/blob/521829cb549801fd9479e673f2cc343d6e52aeb2/lisp/init-flymake.el#L5

Sorry to bother, I don't know much about elisp. This line has syntax error, it might be (maybe-require-package 'flymake (version-to-list "1.2.1")) ?

purcell commented 2 years ago

Why do you feel that is necessary? The CI passes with the existing line. Did you encounter some sort of issue?

demokn commented 2 years ago

I got some error like Couldn’t install optional package ‘flymake’: (wrong-type-argument listp "1.2.1"). It also appears in the CI log.

ghost commented 2 years ago

@purcell ./test-startup.sh

2022-03-29 122756

karlacio commented 2 years ago

I got some error like Couldn’t install optional package ‘flymake’: (wrong-type-argument listp "1.2.1"). It also appears in the CI log.

Same here.

purcell commented 2 years ago

Fixed now, thanks folks!