search

purcell / envrc

Emacs support for direnv which operates buffer-locally
378 stars 35 forks source link

Fix setting of PATH in eshell for Emacs 29.0.1 #51

Closed accelbread closed 2 years ago

accelbread commented 2 years ago

On the Emacs master branch, eshell-path-env has been replaced by the function eshell-set-path. This causes the eshell path to not be updated by envrc-mode. This commit fixes this by using eshell-set-path instead, when it is available.

purcell commented 2 years ago

Thanks. Does it still work buffer-locally?

accelbread commented 2 years ago

Yes, it works buffer-locally. It also works with TRAMP now (though pretty sure tramp ones are shared). The new version uses connection-local variables.

accelbread commented 2 years ago

eshell-path-env still exists but no longer functions; Its docs say "This variable is obsolete since 29.1; use ‘eshell-get-path’ instead."

purcell commented 2 years ago

Great, thank you!