purcell / exec-path-from-shell

Make Emacs use the $PATH set up by the user's shell
Other
1.41k stars 81 forks source link

Adding `exec-path-from-shell` to NonGNU ELPA #111

Closed skangas closed 1 year ago

skangas commented 1 year ago

Hi @purcell,

I would like to suggest adding exec-path-from-shell to NonGNU ELPA. I think you're already aware of the implications, but to re-iterate, the only technical requirement I see is adding a correct ;; Version: header.

What do you think?

purcell commented 1 year ago

I'm not averse to doing this sort of thing, for various projects, but can you point me to info about the appropriate process? ie. Are things still driven off tags, what about when master evolves for months but a Version header isn't updated etc.? What can go wrong, and what do I need to be aware of? This lack of info is what has held me back from doing anything, since my time is currently super limited.

skangas commented 1 year ago

I'm not averse to doing this sort of thing, for various projects, but can you point me to info about the appropriate process? ie. Are things still driven off tags, what about when master evolves for months but a Version header isn't updated etc.? What can go wrong, and what do I need to be aware of?

Alas, there is no such resource besides the README, which admittedly is a bit of a long read. (I'm thinking about maybe putting together a FAQ, but nothing like that exists, yet.) So I hope the following answers will suffice:

As for the process, I'm happy to make all necessary changes on our end to add the package. You only need to bump the Version header when you think it makes sense.

This lack of info is what has held me back from doing anything, since my time is currently super limited.

Understandable, and thank you in advance. Please let me know if you have any other questions or concerns.

I hope that helps.

purcell commented 1 year ago

A bit late, but version header is now added, and I'll maintain that in future, so feel free to add to NonGNU ELPA if that's helpful to folks.

skangas commented 11 months ago

Thanks!

Philip Kaludercic has now added the package: https://elpa.nongnu.org/nongnu/exec-path-from-shell.html

purcell commented 11 months ago

Great, thanks for letting me know!

schneeschmelze commented 11 months ago

Important and great news indeed. Thanks for sharing. YMMV, but I think the package should become a regular part of GNU Emacs for macOS.

skangas commented 11 months ago

YMMV, but I think the package should become a regular part of GNU Emacs for macOS.

I think we will welcome volunteers working on solving this issue in Emacs core, indeed.

If anyone wants to work on that, please open a new feature request/bug report.

purcell commented 11 months ago

YMMV, but I think the package should become a regular part of GNU Emacs for macOS.

Maybe. These days I personally favour a healthy and responsive package ecosystem that can receive updates between Emacs releases rather than a huge central standard library. IMO most of the significant progress in the wider ecosystem over the last 10 years has taken place this way, except where core Emacs facilities like tree-sitter and module support have been required to enable them. But I understand there are different views.

skangas commented 11 months ago

Maybe. These days I personally favour a healthy and responsive package ecosystem that can receive updates between Emacs releases rather than a huge central standard library. IMO most of the significant progress in the wider ecosystem over the last 10 years has taken place this way, except where core Emacs facilities like tree-sitter and module support have been required to enable them. But I understand there are different views.

Perhaps I'm missing your point, but I see no fundamental contradiction between bundling features with Emacs, and being able to update packages between releases: that's what :core packages are for. But I'm also not in favor of a "huge" central standard library, on the contrary. I'm definitely leaning towards being proactive about getting rid of cruft.

In my view, fundamental problems affecting every user of a port should be solved in core. It's rather unfortunate that many (most?) macOS users are currently more or less forced to unbreak Emacs by installing exec-path-from-shell.

That said, I'm happy that this package exists, of course, since it serves a real need.

schneeschmelze commented 11 months ago

Thanks for elaborating on your points of view. My suggestion stems from my recent experience with switching from Aquamacs to Vanilla. LuaTeX did not work out of the box when calling it from Emacs because it missed the values from environment variables. By now I need LuaLaTeX as standard engine. The problem is mentioned in the Emacs manual, but exec-path-from-shell is not. I'm not sure how to amend this, except for including the package in core. But, as said, YMMV. No reason to hurry, as search engines exist.

purcell commented 11 months ago

@skangas The situation is certainly better these days now that built-in packages can be updated between releases. And I certainly agree re. "fundamental problems affecting every user of a port should be solved in core".