purcell / exec-path-from-shell

Make Emacs use the $PATH set up by the user's shell
Other
1.43k stars 82 forks source link

Option to disable -i #13

Closed swsnr closed 10 years ago

swsnr commented 10 years ago

In a proper Zsh setup with .zshenv, -i is redundant. Hence, it'd be nice to have a way to remove -i from the shell command line used by this package.

Before opening a PR, I'd like to discuss the implementation first, since we can essentially choose between to different approaches:

I'd favour the latter, but I'd like to get your OK before implementing it.

purcell commented 10 years ago

Great, yes, I'm generally +1 on this.

I'm not sure about making the whole list customizable, since the order is important: we need -c and the printf expression to be together. So perhaps we could hardcode the -c expr part, and make the other args a customizable list?

And I think I'd still like the -i to be included by default, just to make it work out-of-the-box for more people: I don't fancy dealing with lots of tickets if we suddenly turn off -i. :-)

swsnr commented 10 years ago

@purcell That was exactly my idea, see #14.