search

purcell / exec-path-from-shell

Make Emacs use the $PATH set up by the user's shell
Other
1.43k stars 82 forks source link

Remove unnecessary dash to appease old csh #28

Closed emacs18 closed 9 years ago

emacs18 commented 9 years ago

/bin/csh on Red Hat 5 that I use is a symlink to tcsh version 6.14 built over 10 years ago. This csh fails due to presence of the dash. Removing the dash resolved the problem for me. I don't know what the purpose of the dash was in the first place. If it was an optional character, then I would suggest that you remove this to allow older shells to work.

emacs18 commented 9 years ago

csh manual on ubuntu 14.04 says this regarding -l option:

 -l     The shell is a login shell (only applicable if -l is the only flag
        specified).

Thus using -l along with any other option seems to be illegal for csh as is done within exec-path-from-shell package.

emacs18 commented 9 years ago

I'm sorry. Please ignore previous comment. It was meant for another pull request that I'm about to make.

purcell commented 9 years ago

Thanks, I spent a while investigating this and I also can't see a reason for the -, so I've gone ahead and merged the PR.