search

purcell / flycheck-ledger

A flychecker for checking ledger files
GNU General Public License v3.0
29 stars 5 forks source link

Add another checker to verify that some accounts have a zero value #8

Closed DamienCassou closed 6 years ago

DamienCassou commented 6 years ago

I'm not confident with flycheck API as I've just learned it but it seems to work.

/cc @fmdkdd: care to give some feedback?

DamienCassou commented 6 years ago

The idea is that the user might have some accounts that should always be 0 (e.g., Assets:Budget:Unbudgeted). This new checker will underline the last occurence of a zero account that has non zero value.

DamienCassou commented 6 years ago

Thank you very much for your detailed feedback. I think I applied everything. The result is much simpler. Thanks again.

DamienCassou commented 6 years ago

I improved the PR to fix a bug when zero-accounts have a common root account.

purcell commented 6 years ago

Nice, thanks