search

purcell / ibuffer-vc

Let Emacs' ibuffer-mode group files by git project etc., and show file state
171 stars 11 forks source link

Add file-readable-p check to filter function #8

Closed thomasf closed 9 years ago

thomasf commented 9 years ago

This prohibits ibuffer crash when a file/directory is moved/deleted.

purcell commented 9 years ago

What vc backend does this cause problems with? If it's svn, the problem is described in https://github.com/purcell/ibuffer-vc/issues/6, along with a workaround. The submitter there suggested the same workaround, but as a general solution it is undesirable.

thomasf commented 9 years ago

The only ibuffer-vc feature I am using is '(vc-status-mini 1 1)' and it was from a git repository.

thomasf commented 9 years ago

For all other purposes I have stolen the guts of ibuffer-vc and am using it with projectile instead ( https://github.com/bbatsov/projectile/pull/499/files )

thomasf commented 9 years ago

I cannot reproduce it easily. The backtrace did verify that this should be a sensible solution at the moment. Iirc the error originated somewhere deep inside many levels of nested vc-functions so I guess it could be argued to be a vc bug as well.

I am currently both starting up a project while also learning golang so I refactor/move stuff around and jump between branches and so on quite alot to get packages/design right.. I have bumped into this a few times already.

Will take a more detailed look and also save the backtrace next time it happens.. Possibly it it is triggered by some non trivial scenario.

thomasf commented 9 years ago

I have used ibuffer-vc alot with many unreadable files in buffers and it hasnt happened again.. Maybe it was something else that caused it that has stopped doing so.. I'll take a closer look if it will happens again later.