search

purcell / package-lint

A linting library for elisp package metadata
GNU General Public License v3.0
192 stars 33 forks source link

Accept Package-Requires header without version #232

Closed kyanagi closed 2 years ago

kyanagi commented 2 years ago

According to the manual, an entry in Package-Requires header may lack a version string. An entry without a version is considered to have version "0". https://www.gnu.org/software/emacs/manual/html_node/elisp/Library-Headers.html

So we should accept it.

purcell commented 2 years ago

You might be interested in the background to this warning: this is not legal syntax in all the versions of Emacs that have (or are supported by) package.el. So this means if one uses the syntax, packages will be reported as malformed on certain Emacs/package.el combinations, rather than simply uninstallable. As such, it makes sense for package-lint to direct users to avoid the less-compatible syntax.

However, based on the CI results, it looks like that must have only have affected Emacs 23.4 and the very old standalone version of package.el which supported it, so we could choose to disregard this issue, and I think it would be a good idea to do so.

So I'll go ahead and merge this — thanks for taking the time to submit it.