look for installable packages from the correct places

purcell / package-lint

A linting library for elisp package metadata

GNU General Public License v3.0

192 stars 33 forks source link

look for installable packages from the correct places #233

Closed wyuenho closed 8 months ago

wyuenho commented 2 years ago

package-archive-contents is empty until a package-refresh-contents and friends call is made to fetch from the archives, it also does not contain any builtin packages. This PR make package-lint--check-packages-installable look for the list of package descriptors from the builtins list, installed list and the archive cache.

wyuenho commented 2 years ago

Not entirely sure what to do with CI. I need package--from-builtin that is not available on Emacs < 24.4 and that text-quoting-style let binding error seems to be an existing bug in package-lint in that it's not able to distinguish a let binding from a function call.

This error on emacs < 27 is also very mysterious to me as line 43 is an empty line.

package-lint-test.el:43:0: error: "Types" doesn't start with package's prefix "package-lint-test".

wyuenho commented 1 year ago

@purcell Do you have any feedback on this PR?

purcell commented 1 year ago

Hey - basic idea looks good, thanks! I need to think about a couple of issues:

Lint results should be the same in any Emacs, so need to be careful about issues like that reported under Emacs 26.1 with these changes: package-lint.el:10:38: warning: Version dependency for let-alist appears too high: try 1.0.5. Here there is indeed a 1.0.6 in GNU ELPA, so this must be due to cached or built-in package info.
Also need to think about any downstream effects of increasing the lower Emacs version bound for this library, as this change will break a bunch of CI configs — that's probably legitimate, but needs some sort of communication, and perhaps config examples.

purcell commented 1 year ago

Unsure why CI is failing here with the error

package-lint-test.el:844:0: error: "Types" doesn't start with package's prefix "package-lint-test".

Probabaly related to the imenu code in package-lint — perhaps a problem was this was accidentally masked by the previous CI config.

purcell commented 8 months ago

A change that should have the same effect as this is included in package-lint now, so I'll go ahead and close this — thanks!