search

purcell / package-lint

A linting library for elisp package metadata
GNU General Public License v3.0
196 stars 34 forks source link

Reconsidering / as a Non-standard Sepator? #265

Closed WammKD closed 8 months ago

WammKD commented 8 months ago

/'s used in a lot of packages as a separator in function names and a variety of inbuilt Emacs packages (such as pcomplete/ag in pcmpl-x.el and eshell/cat in em-unix.el) likewise make use of /.

Obviously, it shouldn't be the first separator you reach for but it seems somewhat of overkill to call out a separator which is fairly widely (standardly) used?

purcell commented 8 months ago

There can be a few legitimate uses, but they're enormously less common than folks misusing prefix/ instead of prefix- or prefix--. So I wouldn't want to permit these prefixes explicitly. Some specific uses are already white-listed by package-lint, IIRC.

WammKD commented 8 months ago

Some specific uses are already white-listed by package-lint, IIRC.

I hadn't known that; do you know the general area I'd look to find what they are?

purcell commented 8 months ago

Here, for example: https://github.com/purcell/package-lint/blob/fce93b7edf4e971b2cbe3425c1d773ffe0aa8a62/package-lint.el#L199-L202

purcell commented 8 months ago

I'll close this, then, because our (MELPA) review standards have been consistent for a long time, and have strongly discouraged non-standard separators.