Welcome Page, Disable, and Analytics

purduesigbots / pros-atom

Main plugin for supporting PROS development in Atom

http://atom.io/packages/pros

Mozilla Public License 2.0

11 stars 9 forks source link

Welcome Page, Disable, and Analytics #14

Closed edjubuh closed 7 years ago

edjubuh commented 7 years ago

Collecting a bunch of changes into a single pull request

HotelCalifornia commented 7 years ago

man this will be a fun merge conflict

HotelCalifornia commented 7 years ago

the version thing doesn't work, but we're probably overthinking it.

currently, there are two functions in lib/utils.coffee that call child_process.exec() to find the versions using the command line. This works (probably), but the calls are asynchronous so the welcome view is generated before the version functions are completed. Also, calling child_process.execSync() (which should be the synchronous version of the other function) generates some weird permission errors.

HotelCalifornia commented 7 years ago

This looks good to merge at this point