purduesigbots / pros

Source code for PROS kernel: open source C/C++ development for the VEX V5 microcontroller

https://pros.cs.purdue.edu

Other

259 stars 76 forks source link

✨Adding ctors to Motor_Group #499

Closed aaryan-gautam closed 1 year ago

aaryan-gautam commented 1 year ago

470

djava commented 1 year ago

How is this different from my pr?

WillXuCodes commented 1 year ago

Be sure to credit @djava as a co-author, I think he's just opening this on PROS 4 instead of PROS 3.

WillXuCodes commented 1 year ago

also... needs doxygen comments

djava commented 1 year ago

Pros 4 motor groups are totally different though, shouldn't that just go in #489?

WillXuCodes commented 1 year ago

Pros 4 motor groups are totally different though, shouldn't that just go in #489?

yeah after #489 gets merged we'll actually take a look at this, ideally this work should've been done on that PR branch but at this point merging this after 489 is the path of least resistance.

WillXuCodes commented 1 year ago

Closed as duplicate to #470