✨ PROS 4: Make Class Constructors Explicit - Githubissues

purduesigbots / pros

Source code for PROS kernel: open source C/C++ development for the VEX V5 microcontroller

https://pros.cs.purdue.edu

Other

259 stars 76 forks source link

✨ PROS 4: Make Class Constructors Explicit #522

Closed ryan-doan closed 1 year ago

ryan-doan commented 1 year ago

Summary:

Add "explicit" to devices' constructors.

Motivation:

Prevent implicit copies and conversion of classes.

References (optional):

PROS 4: Rotation Class ctors not explicit https://github.com/purduesigbots/pros/issues/515

Test Plan:

[x] Compile
[x] Check for exceptions to explicit and constructors missing explicit
[x] pros::Rotation rot = pros::Rotation(1); should be invalid (might be prudent to check every constructors).