Closed SizzinSeal closed 1 year ago
Somewhat poorly worded issue, looks like he just wants the ADIEncoder ctor to have a default value for the reversed parameter.
Somewhat poorly worded issue, looks like he just wants the ADIEncoder ctor to have a default value for the reversed parameter.
What they're after is perfectly clear from their description.
Somewhat poorly worded issue, looks like he just wants the ADIEncoder ctor to have a default value for the reversed parameter.
It does have a default parameter and yet it does not build
ADI.hpp, line 499:
ADIEncoder(ext_adi_port_tuple_t port_tuple, bool reversed = false);
Oh, I see. We have multiple ctors and C++ can't decide which one is right for your case. I'm guessing that it can't be fixed in PROS 3, but we'll take a look.
Fixed! Thank you for the issue.
Expected Behavior:
An ADIEncoder should be able to be constructed without giving a value for whether it should be reversed or not.
Actual Behavior:
When passing a tuple for the port (when the user uses a 3-wire expander), the user has to pass a boolean as well for specifying whether the encoder should be reversed or not. Otherwise it does not build.
Steps to reproduce:
Below is some example code
System information:
Platform: V5 PROS Kernel Version: 3.7.3
Screenshots/Output Dumps/Stack Traces