purduesigbots / pros

Source code for PROS kernel: open source C/C++ development for the VEX V5 microcontroller
https://pros.cs.purdue.edu
Other
259 stars 76 forks source link

:bug: PROS 3.8: ADIEncoder Ambiguous Default Constructor #533

Closed WillXuCodes closed 1 year ago

WillXuCodes commented 1 year ago

Summary:

Closes:

526

Makes it unambigious by deleting the copy constructor for ADIEncoder. While this is a breaking change this should not really effect many codebases that attempt to do this.

Test Plan:

image

Does not break ABI for any of these major templates.

WillXuCodes commented 1 year ago

image

Also proof that this compiles and fixes the underlying problem.