Pros4/feature/converting constructor

purduesigbots / pros

Source code for PROS kernel: open source C/C++ development for the VEX V5 microcontroller

https://pros.cs.purdue.edu

Other

259 stars 76 forks source link

Pros4/feature/converting constructor #571

Closed ryan-doan closed 11 months ago

ryan-doan commented 1 year ago

Summary:

Add dynamic instantiation by a device constructor that takes another device object

Motivation:

References (optional):

PROS 4.0.4: Add Converting Constructors for Each Device Class #569

Test Plan:

[x] Compile
[x] Create a device object with a different subclass which is used to instantiate a device object of another subclass. Is_installed is then called to verify conversion is successful.

noam987 commented 1 year ago

I'm going to wait with this until after initial open beta release. We need to think about whether or not some of the devices need to be be explicit constructors or not. This is not critical or a major bug for initial release, more of a QOL feature

noam987 commented 11 months ago

Stale PR